jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ignasi Barrera <notificati...@github.com>
Subject Re: [jclouds-labs] CloudSigma2 ComputeService and SecurityGroupExtension (#70)
Date Tue, 21 Oct 2014 21:09:16 GMT
@demobox I think all comments are addressed now.

The only remaining bit is the visibility of the maps in the module class, but the option is
to move them to their own class/function, which won't make it "less" visible to users. They
are already annotated as visible for testing, but would be nothing wrong in using them directly,
if a user wanted to. Are you OK of leaving the maps as they are, or do you prefer to move
them to their own class or similar?

Otherwise, good to merge?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/70#issuecomment-59999177
Mime
View raw message