jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Phillips <notificati...@github.com>
Subject Re: [jclouds-labs] CloudSigma2 ComputeService and SecurityGroupExtension (#70)
Date Wed, 01 Oct 2014 04:42:29 GMT
> +import org.jclouds.scriptbuilder.domain.StatementList;
> +import org.jclouds.scriptbuilder.statements.ssh.InstallRSAPrivateKey;
> +import org.jclouds.ssh.SshKeys;
> +import org.testng.annotations.Test;
> +
> +import java.util.Map;
> +
> +import static org.testng.Assert.assertEquals;
> +import static org.testng.Assert.assertNull;
> +import static org.testng.Assert.assertTrue;
> +
> +/**
> + * Unit tests for the {@link TemplateOptionsToStatementWithoutPublicKey} class.
> + */
> +@Test(groups = "unit", testName = "TemplateOptionsToStatementWithoutPublicKeyTest")
> +public class TemplateOptionsToStatementWithoutPublicKeyTest {

> I don't get your comment. 

Sorry, my comment was indeed a bit short ;-) I had [commented above](https://github.com/jclouds/jclouds-labs/pull/70/files#r17825992)
about some logic in `TemplateOptions` that modifies `options` (by calling `nameTask`) under
certain conditions. I don't see a corresponding test for that behaviour.

I'm not saying we _need_ one, just wanted to point that out ;-)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/70/files#r18261068
Mime
View raw message