jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ilya Kulakov <notificati...@github.com>
Subject Re: [jclouds-labs] CloudSigma2 ComputeService and SecurityGroupExtension (#70)
Date Thu, 02 Oct 2014 22:43:37 GMT
> +      }).to(FirewallRuleToIpPermission.class);
> +
> +      bind(TemplateOptions.class).to(CloudSigma2TemplateOptions.class);
> +      bind(TemplateOptionsToStatement.class).to(TemplateOptionsToStatementWithoutPublicKey.class);
> +
> +      bind(new TypeLiteral<SecurityGroupExtension>() {
> +      }).to(CloudSigma2SecurityGroupExtension.class);
> +   }
> +
> +   @Override
> +   protected Optional<SecurityGroupExtension> provideSecurityGroupExtension(Injector
i) {
> +      return Optional.of(i.getInstance(SecurityGroupExtension.class));
> +   }
> +
> +   @VisibleForTesting
> +   public static final Map<ServerStatus, NodeMetadata.Status> serverStatusToNodeStatus
= ImmutableMap

@demobox If I make them protected they become invisible to tests. E.g. I get the following
error in `ServerInfoToNodeMetadataTest.java`:

    jclouds-labs/cloudsigma2/src/test/java/org/jclouds/cloudsigma2/compute/functions/ServerInfoToNodeMetadataTest.java:[60,1]
cannot find symbol
    [ERROR] symbol:   static serverStatusToNodeStatus
    [ERROR] location: class
    ...
    jclouds-labs/cloudsigma2/src/test/java/org/jclouds/cloudsigma2/compute/functions/ServerInfoToNodeMetadataTest.java:[170,13]
cannot find symbol
    [ERROR] symbol:   variable serverStatusToNodeStatus
    [ERROR] location: class org.jclouds.cloudsigma2.compute.functions.ServerInfoToNodeMetadataTest

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/70/files#r18372761
Mime
View raw message