jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ignasi Barrera <notificati...@github.com>
Subject Re: [jclouds-labs] CloudSigma2 ComputeService and SecurityGroupExtension (#70)
Date Fri, 03 Oct 2014 08:27:53 GMT
> +      this.driveCloned = checkNotNull(driveCloned, "driveCloned");
> +      this.serverStopped = checkNotNull(serverStopped, "serverStopped");
> +      this.destroyDrives = destroyDrives;
> +      this.groupNamingConvention = checkNotNull(groupNamingConvention, "groupNamingConvention").create();
> +   }
> +
> +   @Override
> +   public NodeAndInitialCredentials<ServerInfo> createNodeWithGroupEncodedIntoName(String
group, String name,
> +                                                                                   Template
template) {
> +      CloudSigma2TemplateOptions options = template.getOptions().as(CloudSigma2TemplateOptions.class);
> +      Image image = template.getImage();
> +      Hardware hardware = template.getHardware();
> +
> +      DriveInfo drive = api.getLibraryDrive(image.getProviderId());
> +
> +      if (!drive.getMedia().equals(MediaType.CDROM)) {

Not sure if that log is needed. CD-ROM drives don't require a clone operation, but they are
used later. I mean, these drives are "not skipped", but not cloned. Other drives that require
the clone print the log for that.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/70/files#r18385378
Mime
View raw message