jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Phillips <notificati...@github.com>
Subject Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good code. (#76)
Date Wed, 01 Oct 2014 05:13:37 GMT
> +         // TODO Since the roleName should be unique, is it a good idea to copy it ?
> +         return this.name(in.getName()).sourceImageName(in.getSourceImageName()).username(in.getUsername())
> +               .password(in.getPassword()).size(in.getSize());
> +      }
> +   }
> +
> +   private final String name;
> +   private final String sourceImageName;
> +   private final String username;
> +   private final String password;
> +   private final String storageAccount;
> +   private final RoleSize size;
> +   private final OSType osType;
> +   private final List<InputEndpoint> endpoints;
> +
> +   public DeploymentParams(String name, String sourceImageName, String username, String
password, String storageAccount,

See comment above about domain object constructor visibility

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76/files#r18261657
Mime
View raw message