jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Adrian Cole <notificati...@github.com>
Subject Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good code. (#76)
Date Wed, 01 Oct 2014 05:13:41 GMT
> +         this.roleName = roleName;
> +         return this;
> +      }
> +
> +      public Deployment build() {
> +         return new Deployment(deploymentName, deploymentSlot, deploymentStatus, deploymentLabel,
deploymentURL,
> +               roleName, instanceName, instanceStatus, instanceStateDetails, instanceErrorCode,
instanceSize,
> +               privateIpAddress, publicIpAddress);
> +      }
> +
> +   }
> +
> +   /**
> +    * The user-supplied name for this deployment.
> +    */
> +   private final String deploymentName;

hah yeah good point. I'm not done with these files. They'll probably need a couple more sweeps
(hopefully ok in follow-up pull requests)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76/files#r18261660
Mime
View raw message