jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Adrian Cole <notificati...@github.com>
Subject Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good code. (#76)
Date Wed, 01 Oct 2014 05:34:54 GMT
>  
> -	private List<String> elements = Lists.newArrayList();
> -	protected StringBuilder currentText = new StringBuilder();
> -	private Deployment.Builder builder = Deployment.builder();
> +   @Override
> +   public Deployment getResult() {
> +      try {
> +         return builder.build();
> +      } finally {
> +         builder = Deployment.builder();
> +      }

the approach you are commenting on is in a ton of other files, but yeah, we can do the shell
game instead of try and reset.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76/files#r18262023
Mime
View raw message