jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Adrian Cole <notificati...@github.com>
Subject Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good code. (#76)
Date Wed, 01 Oct 2014 05:36:32 GMT
> +         this.osType = osType;
> +         return this;
> +      }
> +
> +      public Builder endpoint(InputEndpoint endpoint) {
> +         endpoints.add(endpoint);
> +         return this;
> +      }
> +
> +      public DeploymentParams build() {
> +         return new DeploymentParams(name, sourceImageName, username, password, storageAccount,
size, osType,
> +               endpoints);
> +      }
> +
> +      public Builder fromDeploymentParams(DeploymentParams in) {
> +         // TODO Since the roleName should be unique, is it a good idea to copy it ?

maybe. this is an old comment and I've not analyzed this or the other todos, yet

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76/files#r18262060
Mime
View raw message