jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Phillips <notificati...@github.com>
Subject Re: [jclouds-labs-google] Convert GoogleComputeEngine to AutoValue + general cleanup. (#73)
Date Mon, 03 Nov 2014 21:05:32 GMT
> @@ -113,18 +102,15 @@ public GoogleComputeEngineServiceAdapter(GoogleComputeEngineApi
api,
>                                              @Named(OPERATION_COMPLETE_TIMEOUT) Long
operationCompleteCheckTimeout,
>                                              @Memoized Supplier<Map<URI, ? extends
Location>> zones,
>                                              FirewallTagNamingConvention.Factory firewallTagNamingConvention)
{
> -      this.api = checkNotNull(api, "google compute api");
> -      this.userProject = checkNotNull(userProject, "user project name");
> -      this.metatadaFromTemplateOptions = checkNotNull(metatadaFromTemplateOptions,
> -              "metadata from template options function");
> -      this.operationCompleteCheckInterval = checkNotNull(operationCompleteCheckInterval,
> -              "operation completed check interval");
> -      this.operationCompleteCheckTimeout = checkNotNull(operationCompleteCheckTimeout,
> -                                                        "operation completed check timeout");
> +      this.api = api;
> +      this.userProject = userProject;
> +      this.metatadaFromTemplateOptions = metatadaFromTemplateOptions;
> +      this.operationCompleteCheckInterval = operationCompleteCheckInterval;
> +      this.operationCompleteCheckTimeout = operationCompleteCheckTimeout;

No need to check for `null` here or does Guice take care of this?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/73/files#r19763979
Mime
View raw message