jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Phillips <notificati...@github.com>
Subject Re: [jclouds] JCLOUDS-753: Make ConnectionSpec configurable in the OkHttp driver (#619)
Date Sun, 30 Nov 2014 23:53:34 GMT
> @@ -85,12 +85,19 @@ protected static MockWebServer mockWebServer(Dispatcher dispatcher)
throws IOExc
>      * Creates a test api for the given class and URL.
>      */
>     protected <T extends Closeable> T api(Class<T> apiClass, String url)
{
> +      return api(apiClass, url, createConnectionModule());
> +   }
> +
> +   /**
> +    * Creates a test api for the given class, URI and Module.
> +    */
> +   protected <T extends Closeable> T api(Class<T> apiClass, String url,
Module connectionModule) {

[minor] If we're going to add an overloaded version anyway, allow the caller to pass an arbitrary
set/list/collection of additional modules?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/619/files#r21065183
Mime
View raw message