jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ignasi Barrera <notificati...@github.com>
Subject Re: [jclouds-labs-openstack] Initial support for OpenStack Poppy Service API (#178)
Date Fri, 06 Feb 2015 23:31:24 GMT
I've just looked at the model classes and this is really cool and very clean! Just one minor,
according to the auto docs, you could add a non-static method that returns the Builder (typically
toBuilder()) and auto will mplement it and populate the builder with the current values. It's
just one line worth adding for read/write objects. WDYT?

The builder thing looks really great (I'll look at the rest of the PR with more detail later)
so let's use it in the other repos if it works well. Thanks @jdaggett!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/178#issuecomment-73332649
Mime
View raw message