jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ignasi Barrera <notificati...@github.com>
Subject Re: [jclouds-labs] JCLOUDS-782: init for shipyard provider (#116)
Date Tue, 03 Feb 2015 10:28:40 GMT
This is a good start with the Mock tests. But there are a couple things you have to address
in all them:

* Add tests for failed responses (404, etc), for all methods where you explicitly define a
`@Fallback`. Mock tests also have to verify that the fallback takes place when needed.
* In all tests that procude a body, you also need to verify that the generated body is the
right one.
* In the `assertSent` method, add a check for the authentication header, to make sure the
filter configured in each API is behaving properly too.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/116#issuecomment-72627675
Mime
View raw message