jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ignasi Barrera <notificati...@github.com>
Subject Re: [jclouds-labs] JCLOUDS-702: JClouds ProfitBricks provider - Storage API (#128)
Date Mon, 02 Feb 2015 15:09:49 GMT
>is this change better?

Yes, it is better, but take into account that if the `isSoapPayload` returns false you are
not updating the payload in the response, and the original input stream might be already read.
I'd put the soap check inside the try/finally block to make sure the response always has a
readable payload when exiting the method.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/128#issuecomment-72472553
Mime
View raw message