jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Everett Toews <notificati...@github.com>
Subject Re: [jclouds-labs-openstack] Poppy service api (#179)
Date Mon, 09 Mar 2015 12:03:34 GMT
> +   @Fallback(NullOnNotFoundOr404.class)
> +   @Nullable
> +   Service get(@PathParam("id") String id);
> +
> +   /**
> +    * Creates a service.
> +    *
> +    * @param options  the options to create the service with
> +    * @return a URI to the created service
> +    */
> +   @Named("service:create")
> +   @POST
> +   @ResponseParser(ParseServiceURIFromHeaders.class)
> +   @Fallback(NullOnNotFoundOr404.class)
> +   @Nullable
> +   URI create(CreateService options);

`options` is an odd name for this param. In `update()` it's called `updateService`. I suggest
`createService `.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/179/files#r26030007
Mime
View raw message