jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ignasi Barrera <notificati...@github.com>
Subject Re: [jclouds-labs] Profitbricks IpBlock API (#141)
Date Mon, 02 Mar 2015 15:01:28 GMT
> +   }
> +
> +   @Test
> +   public void testReservePublicIpBlock() {
> +      newIpBlock = api.ipBlockApi().reservePublicIpBlock("2", Location.US_LAS.value());
> +
> +      assertNotNull(newIpBlock);
> +      assertNotNull(newIpBlock.ips());
> +      assertFalse(newIpBlock.ips().isEmpty());
> +   }
> +
> +   @Test
> +   public void testGetAllIpBlocks() {
> +      List<IpBlock> ipBlocks = api.ipBlockApi().getAllIpBlock();
> +
> +      assertNotNull(ipBlocks);

The jclouds fallback always returns a list (or an empty one). Should we better add some assertion
to verify that the list has the expected elements?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/141/files#r25603854
Mime
View raw message