jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ignasi Barrera <notificati...@github.com>
Subject Re: [jclouds-labs] JClouds Profitbricks provider - LoadBalancer API (#143)
Date Mon, 09 Mar 2015 17:05:27 GMT
> +import org.jclouds.profitbricks.http.parser.server.ServerListResponseHandler;
> +import org.xml.sax.Attributes;
> +import org.xml.sax.SAXException;
> +
> +public abstract class BaseLoadBalancerResponseHandler<T> extends BaseProfitBricksResponseHandler<T>
{
> +
> +   protected final ServerListResponseHandler balancedServerResponseHandler;
> +   protected final FirewallListResponseHandler firewallListResponseHandler;
> +
> +   protected LoadBalancer.Builder builder;
> +   protected final DateCodec dateCodec;
> +
> +   protected boolean useBalancedServerParser = false;
> +   protected boolean useFirewallParser = false;
> +
> +   protected BaseLoadBalancerResponseHandler(DateCodecFactory dateCodec, ServerListResponseHandler
balancedServerResponseHandler, FirewallListResponseHandler firewallResponseHandler) {

Add null checks for the mandatory parameters. Although subclasses use injection, this class
does not know how subclasses are built, so we'd better check the input parameters here.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/143/files#r26054244
Mime
View raw message