jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jasminSPC <notificati...@github.com>
Subject Re: [jclouds-labs] JClouds Profitbricks provider - LoadBalancer API (#143)
Date Tue, 10 Mar 2015 21:43:06 GMT
> +import org.jclouds.profitbricks.http.parser.server.ServerListResponseHandler;
> +import org.xml.sax.Attributes;
> +import org.xml.sax.SAXException;
> +
> +public abstract class BaseLoadBalancerResponseHandler<T> extends BaseProfitBricksResponseHandler<T>
{
> +
> +   protected final ServerListResponseHandler balancedServerResponseHandler;
> +   protected final FirewallListResponseHandler firewallListResponseHandler;
> +
> +   protected LoadBalancer.Builder builder;
> +   protected final DateCodec dateCodec;
> +
> +   protected boolean useBalancedServerParser = false;
> +   protected boolean useFirewallParser = false;
> +
> +   protected BaseLoadBalancerResponseHandler(DateCodecFactory dateCodec, ServerListResponseHandler
balancedServerResponseHandler, FirewallListResponseHandler firewallResponseHandler) {

Should I throw exception if null? I don't see that we are doing the same here https://github.com/StackPointCloud/jclouds-labs/blob/master/profitbricks/src/main/java/org/jclouds/profitbricks/http/parser/server/BaseServerResponseHandler.java#L50

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/143/files#r26169335
Mime
View raw message