jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ignasi Barrera <notificati...@github.com>
Subject Re: [jclouds] adding attache detach interface to nova api (#697)
Date Mon, 02 Mar 2015 14:43:45 GMT
Thanks @limorbortman! I've done a quick review, and apart from the inline comments, there are
a couple things to address:

* Add a unit test for the `AttachInterfaceOptions` class that verifies the `bindToRequest`
method.
* Format the code according to the [jclouds style guide ](https://cwiki.apache.org/confluence/display/JCLOUDS/Coding+Standards):
3 space indend and 120 line wrap.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/697#issuecomment-76722997
Mime
View raw message