jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zack Shoylev <notificati...@github.com>
Subject Re: [jclouds] Adds autovalue/gson builders tests, for sanity. (#699)
Date Tue, 03 Mar 2015 17:34:51 GMT
Alright, but I think it makes more sense to just delay merging this? The snapshot part is to
make sure the pr compiles. Also with luck they will release before we do.
________________________________________
From: Ignasi Barrera [notifications@github.com]
Sent: Tuesday, March 3, 2015 11:15 AM
To: jclouds/jclouds
Cc: Zack Shoylev
Subject: Re: [jclouds] Adds autovalue/gson builders tests, for sanity. (#699)

-1

While it only affects the tests, we are opening the door to anyone to use it by mistake, and
this must not be used until there is a fixed release.

Also, we only release the source code, and the tarballs we release must produce the same articafts
in each build, at any time. We can't guarantee that by adding a SNAPSHOT dependency. It could
also break the tests of an already published release!

I'm -1 to have this merged to master but also understand the value of having these tests to
allow us to move forward faster once it is released. I suggest to push a branch with this
change (say, auto-1.1) and to add a Jenkins build that verifes it, but SNAPSHOT dependencies
can't be merged into master.

�
Reply to this email directly or view it on GitHub<https://github.com/jclouds/jclouds/pull/699#issuecomment-76989512>.



---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/699#issuecomment-76993591
Mime
View raw message