jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ignasi Barrera <notificati...@github.com>
Subject Re: [jclouds-labs] [JCLOUDS-850] Providing AzureTemplateBuilderLiveTest (#156)
Date Thu, 02 Apr 2015 08:51:14 GMT
> @@ -89,6 +89,14 @@ public void copyTo(final TemplateOptions to) {
>           if (storageAccountType.isPresent()) {
>              eTo.storageAccountType(storageAccountType.get());
>           }
> +
> +         final LoginCredentials credentials = new LoginCredentials.Builder().
> +                 user(loginUser).
> +                 password(loginPassword == null || !loginPassword.isPresent() ? null
: loginPassword.get()).
> +                 privateKey(loginPrivateKey == null || !loginPrivateKey.isPresent()
? null : loginPrivateKey.get()).
> +                 authenticateSudo(authenticateSudo == null ? false : authenticateSudo).
> +                 build();
> +         eTo.overrideLoginCredentials(credentials);

>WDYT? Shall I open an issue / PR about this and leave the fix temporarily here (in order
to keep the test case above working)?

If you can do that, that would be much appreciated. Let's fix jclouds as soon as we find some
issues instead of silo-ing fixes in providers.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/156/files#r27641008
Mime
View raw message