jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ignasi Barrera <notificati...@github.com>
Subject Re: [jclouds] Promote rackspace cloudfiles6 (#705)
Date Mon, 06 Apr 2015 21:23:06 GMT
This one looks much more clean. Thanks for the time and pain suffered to get into this nice
state @zack-shoylev!

Just one comment though: I wouldn't rebase. When promoting providers with such an amount of
commits, I think it is better to keep them "at the moment they were committed", and have the
merge commit:

We want to have a linear history, but just because all contributions are assumed to be made
against the latest version of the integration branch. That is OK for pull requests, but when
promoting a provider, we are not adding *new* contributions, but adding to the repository
contributions that were actually made some time before, so having all those commits on the
top of the git history does not make sense to me and IMO does not provide any benefit. In
this case, I think it is OK to have that merge commit, and I'd really prefer to promote providers
and APIs without rebasing.

WDYT?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/705#issuecomment-90249782
Mime
View raw message