jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrea Turli <notificati...@github.com>
Subject Re: [jclouds] Don't retry unsafe HTTP methods in case of an IOException (#744)
Date Tue, 12 May 2015 07:33:47 GMT
> @@ -90,13 +94,23 @@
>     protected Logger logger = Logger.NULL;
>  
>     public boolean shouldRetryRequest(HttpCommand command, IOException error) {
> -      return ifReplayableBackoffAndReturnTrue(command);
> +      return isSafeToRetryOnException(command) && ifReplayableBackoffAndReturnTrue(command);

what about `isIdempotent(command)` instead of `isSafeToRetryOnException()` ?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/744/files#r30110560
Mime
View raw message