jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Gaul <notificati...@github.com>
Subject Re: [jclouds] tighten the isUrlEncoded check (#755)
Date Thu, 28 May 2015 00:21:39 GMT
This commit causes failures in core for me:

```
  BindMapToStringPayloadTest.testDecodes:76 expected [{"changePassword":{"adminPass":"foo"}}]
but found [%7B"changePassword":%7B"adminPass":"foo"%7D%7D]
  HttpRequestTest.testAddBase64AndUrlEncodedQueryParams:78 expected [GET http://goo.com:443?header1=ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789%2B/%3D&header2=ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789%2B/%3D
HTTP/1.1] but found [GET http://goo.com:443?header1=ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789%20/%3D&header2=ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/=
HTTP/1.1]
  HttpRequestTest.testEncodesOnlyOnce:55 expected [{method=GET, endpoint=http://goo.com:443?header=hello%3F,
headers={}}] but found [{method=GET, endpoint=http://goo.com:443?header=hello?, headers={}}]
  RestAnnotationProcessorTest.testCreateGetRequest:2133 expected [/qu%3Fstion] but found [/qu]
```

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/755#issuecomment-106120072
Mime
View raw message