jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zack Shoylev <notificati...@github.com>
Subject Re: [jclouds-labs] JCLOUDS-826: Add blob operations (#176)
Date Mon, 01 Jun 2015 22:52:41 GMT
>        return metadata;
>     }
>  
>     @Override
> -   public boolean blobExists(String s, String s1) {
> -      return false;
> +   public boolean blobExists(String container, String key) {

At least the parameters in the strategy methods should probably have javadocs, even if the
methods are mostly self-documented. Other stuff that might be useful is null-safety or invalid
characters, if any.
The strategy itself probably needs some javadocs on how stuff is stored.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/176/files#r31479177
Mime
View raw message