jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ignasi Barrera <notificati...@github.com>
Subject Re: [jclouds] [Softlayer] Implements setting and retrieving the notes property (#756)
Date Tue, 09 Jun 2015 21:54:39 GMT
> +import com.google.inject.Inject;
> +import com.google.inject.Singleton;
> +
> +/**
> + * Converts a String into a json string for changing the notes property of an instance
> + * The string is set into the payload of the HttpRequest
> + * 
> + */
> +@Singleton
> +public class NotesToJson implements Binder {
> +
> +   private final Json json;
> +
> +   @Inject
> +   NotesToJson(Json json) {
> +      this.json = checkNotNull(json, "json");

Once the constructor is only visible to the injector, the null check is redundant (the injector
already checks nulls). Remove it.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/756/files#r32069050
Mime
View raw message