jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Iván López <notificati...@github.com>
Subject [jclouds] JCLOUDS-941: Add the Content-Type header for filesystem blobstore (#780)
Date Sun, 21 Jun 2015 11:51:01 GMT
Auto-detect the content-type if it's null.

I think the feature is working in my first commit (135b609). 

In the second one I tried to add the property @andrewgaul suggested in the JIRA but I'm not
really sure if this is the right way to do it. Besides, if I run the tests only for the class
they all pass but when I execute the `install` target some tests fail because this Guice error
that I don't know how to fix it:

```
com.google.inject.CreationException: Guice creation errors:

1) No implementation for java.lang.Boolean annotated with @com.google.inject.name.Named(value=jclouds.filesystem.auto-detect-content-type)
was bound.
  while locating java.lang.Boolean annotated with @com.google.inject.name.Named(value=jclouds.filesystem.auto-detect-content-type)
    for parameter 2 at org.jclouds.filesystem.strategy.internal.FilesystemStorageStrategyImpl.<init>(FilesystemStorageStrategyImpl.java:121)
  at org.jclouds.filesystem.config.FilesystemBlobStoreContextModule.configure(FilesystemBlobStoreContextModule.java:43)
```

@andrewgaul I've been looking how to inject a property from a property file but I don't know
how to do it. Could you please point me to an example or give me a hint how to do it?

Regards, Iván.
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds/pull/780

-- Commit Summary --

  * Auto-detect the Content-Type if it is null
  * WIP: Configure auto detect content-type behaviour

-- File Changes --

    M apis/filesystem/src/main/java/org/jclouds/filesystem/reference/FilesystemConstants.java
(3)
    M apis/filesystem/src/main/java/org/jclouds/filesystem/strategy/internal/FilesystemStorageStrategyImpl.java
(7)
    M apis/filesystem/src/test/java/org/jclouds/filesystem/FilesystemBlobStoreTest.java (1)
    M apis/filesystem/src/test/java/org/jclouds/filesystem/strategy/internal/FilesystemStorageStrategyImplTest.java
(36)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/780.patch
https://github.com/jclouds/jclouds/pull/780.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/780

Mime
View raw message