jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zack Shoylev <notificati...@github.com>
Subject Re: [jclouds-labs-openstack] add FWaaS extension to openstack-neutron (#196)
Date Thu, 02 Jul 2015 01:17:02 GMT
> +public abstract class CreateFirewallPolicy {
> +
> +   @Nullable public abstract String getTenantId();
> +   @Nullable public abstract String getName();
> +   @Nullable public abstract String getDescription();
> +   public abstract boolean isShared();
> +   @Nullable public abstract List<String> getFirewallRules();
> +   public abstract boolean isAudited();
> +
> +   @SerializedNames({"tenant_id", "name", "description", "shared", "firewall_rules",
"audited"})
> +   private static CreateFirewallPolicy create(String tenantId, String name, String description,
boolean shared, List<String> firewallRules, boolean audited) {
> +      return builder().tenantId(tenantId).name(name).description(description).shared(shared).firewallRules(firewallRules).audited(audited).build();
> +   }
> +
> +   public static Builder builder() {
> +      return new AutoValue_CreateFirewallPolicy.Builder();

I am guessing your builder needs to have isShared and isAudited set to default values (false)
here.

Also based on this:
http://docs.openstack.org/admin-guide-cloud/content/fwaas_api_abstractions.html

Please add the corresponding docs for the properties here and in other places as applicable.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/196/files#r33740521
Mime
View raw message