jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ignasi Barrera <notificati...@github.com>
Subject Re: [jclouds-labs] JCLOUDS-826: Add H2 provider (#193)
Date Mon, 27 Jul 2015 08:36:15 GMT
> + * limitations under the License.
> + */
> +package org.jclouds.h2.jdbc;
> +
> +import com.google.auto.service.AutoService;
> +import com.google.common.collect.ImmutableSet;
> +import com.google.inject.Module;
> +import org.jclouds.apis.ApiMetadata;
> +import org.jclouds.blobstore.BlobStoreContext;
> +import org.jclouds.h2.jdbc.config.H2JdbcBlobStoreContextModule;
> +import org.jclouds.jdbc.JdbcApiMetadata;
> +
> +/**
> + * Implementation of {@link H2JdbcApiMetadata} for the H2 database
> + */
> +@AutoService(ApiMetadata.class)

In fact, this class should be removed and let the provider metadata use the `JdbcApiMetadata`
directly. That's how generic apis and providers are supposed to be used. (A provider is an
API + defaults + location).

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/193/files#r35514882
Mime
View raw message