jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ignasi Barrera <notificati...@github.com>
Subject Re: [jclouds-labs] JCLOUDS-971: add statistics and miscellaneous API (#195)
Date Thu, 30 Jul 2015 05:36:18 GMT
Looks pretty good! Just a few comments:

* Only add dependencies when needed: remove the OkHttp driver and the jclouds-compute one.
Regarding the JRE and DELETE requests, IIRC they are supported if they don't have a body.
Having a quick look at the etcd api docs I don't see any DELETE request with a body (I can
be wrong), so the default http driver should work fine and we can let users pick their preferred
driver.
* Live tests right now do not seem to have to be single-threaded. Remove that from the annotation
and also the `threadCount` in the pom.xml.
* Seeing the nature of the MiscApi methods, consider removing the class and moving its methods
to the EtcdApi class. Also move common method annotations to class level.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/195#issuecomment-126190860
Mime
View raw message