jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Gaul <notificati...@github.com>
Subject Re: [jclouds] Removes CopyObjectException in favor of standard blobstore exceptions (#804)
Date Thu, 09 Jul 2015 20:45:12 GMT
> @@ -141,20 +142,17 @@ public void testCopyObject() throws Exception {
>           // test exception thrown on bad source name
>           try {
>              destApi.copy(destinationObject, badSource, sourceObjectName);
> -            fail("Expected CopyObjectException");

Can you use try .. catch instead of `expectedExceptions`?  This narrows the exception handling
scope:

http://konigsberg.blogspot.com/2007/11/testng-and-expectedexceptions-ive.html

(also the for loop above will not complete with this change)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/804/files#r34301542
Mime
View raw message