jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ignasi Barrera <notificati...@github.com>
Subject Re: [jclouds] Fix bug where password information is printed in logs in case of exce… (#830)
Date Wed, 29 Jul 2015 06:58:20 GMT
Thanks @arvindn05! The approach looks pretty clean.

You will also want to check the sensitive flag [in the Wire class](https://github.com/jclouds/jclouds/blob/master/core/src/main/java/org/jclouds/logging/internal/Wire.java#L120-L137),
so the sensitive information does not get printed in the logs with the wire logs are enabled.

Regarding the change, this is something users might want to be able to turn on/off. I mean,
this fix does not only mask the sensitive information, but removes the entire payload from
the logs, and that might not be ideal/wanted by everyone. We should provide a way to disable
this (I'm OK having it enabled by default), such a property one can configure when creating
the context.

/cc @andrewgaul @demobox 

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/830#issuecomment-125863131
Mime
View raw message