jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ignasi Barrera <notificati...@github.com>
Subject Re: [jclouds-labs] [JCLOUDS-1007] Implemented Docker Exec support in MiscApi (#205)
Date Thu, 01 Oct 2015 22:06:09 GMT
> +   @SerializedNames({ "Detach" })
> +   public static ExecStartParams create(boolean detach) {
> +      return builder().detach(detach).build();
> +   }
> +
> +   public static Builder builder() {
> +      return new AutoValue_ExecStartParams.Builder().detach(false);
> +   }
> +
> +   @AutoValue.Builder
> +   public abstract static class Builder {
> +
> +      public abstract Builder detach(boolean b);
> +
> +      public abstract ExecStartParams build();
> +   }

Some domain classes have builders, some not. Should we remove all the builders, given that
these classes are pretty simple, for consistency?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/205/files#r40972202
Mime
View raw message