jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Reijhanniel Jearl Campos <notificati...@github.com>
Subject [jclouds-labs] JCLOUDS-951: Remove inheritance in ProfitBrick's AutoValue classes (#210)
Date Sun, 11 Oct 2015 03:36:04 GMT
Continuing from the ProfitBricks adapter progress left 3 months ago, here's a PR for [JCLOUDS-951](https://issues.apache.org/jira/browse/JCLOUDS-951).

- Inheritance-based domain classes removed
- Now using `@AutoValue.Builder` (ausuum)
- Added missed validations on some domain classes
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds-labs/pull/210

-- Commit Summary --

  * JCLOUDS-951: Remove inheritance in ProfitBrick's AutoValue classes

-- File Changes --

    M profitbricks/src/main/java/org/jclouds/profitbricks/binder/firewall/AddFirewallRuleToNicRequestBinder.java
(2)
    M profitbricks/src/main/java/org/jclouds/profitbricks/binder/loadbalancer/CreateLoadBalancerRequestBinder.java
(4)
    M profitbricks/src/main/java/org/jclouds/profitbricks/binder/loadbalancer/UpdateLoadBalancerRequestBinder.java
(2)
    M profitbricks/src/main/java/org/jclouds/profitbricks/binder/snapshot/UpdateSnapshotRequestBinder.java
(2)
    M profitbricks/src/main/java/org/jclouds/profitbricks/binder/storage/CreateStorageRequestBinder.java
(2)
    M profitbricks/src/main/java/org/jclouds/profitbricks/compute/ProfitBricksComputeServiceAdapter.java
(2)
    M profitbricks/src/main/java/org/jclouds/profitbricks/compute/config/ProfitBricksComputeServiceContextModule.java
(2)
    M profitbricks/src/main/java/org/jclouds/profitbricks/compute/function/ProvisionableToImage.java
(2)
    M profitbricks/src/main/java/org/jclouds/profitbricks/domain/AvailabilityZone.java (9)
    M profitbricks/src/main/java/org/jclouds/profitbricks/domain/DataCenter.java (105)
    M profitbricks/src/main/java/org/jclouds/profitbricks/domain/Drive.java (37)
    M profitbricks/src/main/java/org/jclouds/profitbricks/domain/Firewall.java (328)
    M profitbricks/src/main/java/org/jclouds/profitbricks/domain/Image.java (132)
    M profitbricks/src/main/java/org/jclouds/profitbricks/domain/IpBlock.java (87)
    M profitbricks/src/main/java/org/jclouds/profitbricks/domain/LoadBalancer.java (312)
    M profitbricks/src/main/java/org/jclouds/profitbricks/domain/Location.java (8)
    M profitbricks/src/main/java/org/jclouds/profitbricks/domain/Nic.java (299)
    M profitbricks/src/main/java/org/jclouds/profitbricks/domain/OsType.java (8)
    R profitbricks/src/main/java/org/jclouds/profitbricks/domain/Provisionable.java (12)
    M profitbricks/src/main/java/org/jclouds/profitbricks/domain/ProvisioningState.java (8)
    M profitbricks/src/main/java/org/jclouds/profitbricks/domain/Server.java (477)
    M profitbricks/src/main/java/org/jclouds/profitbricks/domain/ServiceFault.java (45)
    M profitbricks/src/main/java/org/jclouds/profitbricks/domain/Snapshot.java (292)
    M profitbricks/src/main/java/org/jclouds/profitbricks/domain/Storage.java (252)
    D profitbricks/src/main/java/org/jclouds/profitbricks/domain/internal/FirewallRuleCommonProperties.java
(44)
    D profitbricks/src/main/java/org/jclouds/profitbricks/domain/internal/HotPluggable.java
(102)
    D profitbricks/src/main/java/org/jclouds/profitbricks/domain/internal/Provisionable.java
(67)
    M profitbricks/src/main/java/org/jclouds/profitbricks/http/parser/ipblock/BaseIpBlockResponseHandler.java
(7)
    M profitbricks/src/main/java/org/jclouds/profitbricks/http/parser/ipblock/IpBlockResponseHandler.java
(4)
    M profitbricks/src/main/java/org/jclouds/profitbricks/http/parser/loadbalancer/BaseLoadBalancerResponseHandler.java
(2)
    M profitbricks/src/main/java/org/jclouds/profitbricks/http/parser/nic/BaseNicResponseHandler.java
(7)
    M profitbricks/src/main/java/org/jclouds/profitbricks/http/parser/nic/NicListResponseHandler.java
(6)
    M profitbricks/src/main/java/org/jclouds/profitbricks/http/parser/nic/NicResponseHandler.java
(7)
    M profitbricks/src/main/java/org/jclouds/profitbricks/http/parser/publicip/PublicIpListResponseHandler.java
(4)
    M profitbricks/src/main/java/org/jclouds/profitbricks/http/parser/server/BaseServerResponseHandler.java
(2)
    M profitbricks/src/main/java/org/jclouds/profitbricks/http/parser/server/ServerListResponseHandler.java
(4)
    A profitbricks/src/main/java/org/jclouds/profitbricks/util/Preconditions.java (100)
    M profitbricks/src/test/java/org/jclouds/profitbricks/binder/datacenter/CreateDataCenterRequestBinderTest.java
(2)
    M profitbricks/src/test/java/org/jclouds/profitbricks/binder/datacenter/UpdateDataCenterRequestBinderTest.java
(2)
    M profitbricks/src/test/java/org/jclouds/profitbricks/binder/drive/AddRomDriveToServerRequestBinderTest.java
(2)
    M profitbricks/src/test/java/org/jclouds/profitbricks/binder/firewall/AddFirewallRuleToNicRequestBinderTest.java
(27)
    M profitbricks/src/test/java/org/jclouds/profitbricks/binder/loadbalancer/CreateLoadBalancerRequestBinderTest.java
(28)
    M profitbricks/src/test/java/org/jclouds/profitbricks/binder/loadbalancer/DeregisterLoadBalancerRequestBinderTest.java
(2)
    M profitbricks/src/test/java/org/jclouds/profitbricks/binder/loadbalancer/RegisterLoadBalancerRequestBinderTest.java
(2)
    M profitbricks/src/test/java/org/jclouds/profitbricks/binder/loadbalancer/UpdateLoadBalancerRequestBinderTest.java
(19)
    M profitbricks/src/test/java/org/jclouds/profitbricks/binder/snapshot/CreateSnapshotRequestBinderTest.java
(10)
    M profitbricks/src/test/java/org/jclouds/profitbricks/binder/snapshot/RollbackSnapshotRequestBinderTest.java
(5)
    M profitbricks/src/test/java/org/jclouds/profitbricks/binder/snapshot/UpdateSnapshotRequestBinderTest.java
(16)
    M profitbricks/src/test/java/org/jclouds/profitbricks/compute/function/ServerToNodeMetadataTest.java
(2)
    M profitbricks/src/test/java/org/jclouds/profitbricks/domain/FirewallRuleBuilderTest.java
(2)
    M profitbricks/src/test/java/org/jclouds/profitbricks/domain/ServerBuilderTest.java (8)
    M profitbricks/src/test/java/org/jclouds/profitbricks/features/DataCenterApiLiveTest.java
(4)
    M profitbricks/src/test/java/org/jclouds/profitbricks/features/DataCenterApiMockTest.java
(6)
    M profitbricks/src/test/java/org/jclouds/profitbricks/features/DrivesApiLiveTest.java
(2)
    M profitbricks/src/test/java/org/jclouds/profitbricks/features/DrivesApiMockTest.java
(2)
    M profitbricks/src/test/java/org/jclouds/profitbricks/features/FirewallApiLiveTest.java
(14)
    M profitbricks/src/test/java/org/jclouds/profitbricks/features/FirewallApiMockTest.java
(24)
    R profitbricks/src/test/java/org/jclouds/profitbricks/features/LoadBalancerApiLiveTest.java
(39)
    R profitbricks/src/test/java/org/jclouds/profitbricks/features/LoadBalancerApiMockTest.java
(43)
    M profitbricks/src/test/java/org/jclouds/profitbricks/features/NicApiMockTest.java (18)
    M profitbricks/src/test/java/org/jclouds/profitbricks/features/ServerApiLiveTest.java
(7)
    M profitbricks/src/test/java/org/jclouds/profitbricks/features/SnapshotApiLiveTest.java
(10)
    M profitbricks/src/test/java/org/jclouds/profitbricks/features/SnapshotApiMockTest.java
(10)
    M profitbricks/src/test/java/org/jclouds/profitbricks/features/StorageApiLiveTest.java
(6)
    M profitbricks/src/test/java/org/jclouds/profitbricks/http/ResponseStatusFromPayloadHttpCommandExecutorServiceTest.java
(10)
    M profitbricks/src/test/java/org/jclouds/profitbricks/http/parser/datacenter/DataCenterInfoResponseHandlerTest.java
(2)
    M profitbricks/src/test/java/org/jclouds/profitbricks/http/parser/ipblock/IpBlockListResponseHandlerTest.java
(19)
    M profitbricks/src/test/java/org/jclouds/profitbricks/http/parser/ipblock/IpBlockResponseHandlerTest.java
(5)
    M profitbricks/src/test/java/org/jclouds/profitbricks/http/parser/loadbalancer/LoadBalancerListResponseHandlerTest.java
(4)
    M profitbricks/src/test/java/org/jclouds/profitbricks/http/parser/loadbalancer/LoadBalancerResponseHandlerTest.java
(2)
    M profitbricks/src/test/java/org/jclouds/profitbricks/http/parser/nic/NicListResponseHandlerTest.java
(6)
    M profitbricks/src/test/java/org/jclouds/profitbricks/http/parser/nic/NicResponseHandlerTest.java
(8)
    M profitbricks/src/test/java/org/jclouds/profitbricks/http/parser/server/ServerInfoResponseHandlerTest.java
(2)
    M profitbricks/src/test/java/org/jclouds/profitbricks/http/parser/server/ServerListResponseHandlerTest.java
(4)
    M profitbricks/src/test/java/org/jclouds/profitbricks/http/parser/snapshot/SnapshotListResponseHandlerTest.java
(4)
    M profitbricks/src/test/java/org/jclouds/profitbricks/http/parser/snapshot/SnapshotResponseHandlerTest.java
(2)
    M profitbricks/src/test/resources/ipblock/ipblock-reserve.xml (2)
    M profitbricks/src/test/resources/ipblock/ipblock.xml (4)
    M profitbricks/src/test/resources/ipblock/ipblocks.xml (18)
    M profitbricks/src/test/resources/loadbalancer/loadbalancer-create.xml (2)
    M profitbricks/src/test/resources/loadbalancer/loadbalancer-delete.xml (2)
    M profitbricks/src/test/resources/loadbalancer/loadbalancer.xml (2)
    M profitbricks/src/test/resources/loadbalancer/loadbalancers.xml (4)
    M profitbricks/src/test/resources/nic/nic.xml (4)
    M profitbricks/src/test/resources/nic/nics.xml (4)

-- Patch Links --

https://github.com/jclouds/jclouds-labs/pull/210.patch
https://github.com/jclouds/jclouds-labs/pull/210.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/210

Mime
View raw message