jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ignasi Barrera <notificati...@github.com>
Subject Re: [jclouds-labs] JCLOUDS-1027: Use droplet id when waiting for droplet creation (#216)
Date Tue, 27 Oct 2015 09:17:08 GMT
Thanks for the PR @tk421! A couple comments:

* As you'll see above in red, the merged build has failed. The code compiles and tests pass,
but there is a [checkstyle violation](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/911/org.apache.jclouds.labs$digitalocean2/violations/file/src/main/java/org/jclouds/digitalocean2/compute/DigitalOcean2ComputeServiceAdapter.java/).
Can you remove the unused import?
* Also the `nodeRunning` and `nodeStopped` predicates used in [these methods](https://github.com/jclouds/jclouds-labs/blob/master/digitalocean2/src/main/java/org/jclouds/digitalocean2/compute/DigitalOcean2ComputeServiceAdapter.java#L218-L241)
are using the action id instead of the droplet id. Could you change those methods too? (FYI,
the predicates are defined [here](https://github.com/jclouds/jclouds-labs/blob/master/digitalocean2/src/main/java/org/jclouds/digitalocean2/compute/config/DigitalOcean2ComputeServiceContextModule.java#L107-L121)
and [here](https://github.com/jclouds/jclouds-labs/blob/master/digitalocean2/src/main/java/org/jclouds/digitalocean2/compute/config/DigitalOcean2ComputeServiceContextModule.java#L197-L214)).

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/216#issuecomment-151423941
Mime
View raw message