jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Timur Alperovich <notificati...@github.com>
Subject Re: [jclouds] JCLOUDS-1008: Add @Encoded annotation. (#861)
Date Tue, 20 Oct 2015 00:45:21 GMT
I'd like to keep the ```UriBuilder``` as dumb as possible. These encoding issues arose from
the fact that the encoding logic got baked into the ```UriBuilder```, making it hard to maintain
a clean abstraction. Moving encoding out of it makes the most sense. The only question is
what makes more sense: annotation processor or an auxiliary class, such as ```QueryValue```.
Using ```QueryValue``` will allow us to sink the conditional around encoding and out of the
annotation processor itself, so that seems like a win. On the other hand, the code around
extracting the ```@Encoded``` value remains. Let me give it a shot and see what this might
look like.

Also, should we split off this work into another PR? It's becoming a bit more involved and
blocks fixing the actual bug in GCS (addressed by the first commit in this PR).

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/861#issuecomment-149387151
Mime
View raw message