jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ignasi Barrera <notificati...@github.com>
Subject Re: [jclouds] JCLOUDS-1008: Add @Encoded annotation. (#861)
Date Thu, 01 Oct 2015 21:27:17 GMT
> @@ -147,6 +149,7 @@ public Part apply(Entry<String, Object> from) {
>     private final GetAcceptHeaders getAcceptHeaders;
>     private final Invocation caller;
>     private final boolean stripExpectHeader;
> +   private boolean encodedParams;

We should assume the annotation processor could be a singleton and avoid adding state to it.
Consider removing this member variable and an alternate way to get its value in each invocation
to the processor to avoid possible errors in subsequent calls due to an old state.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/861/files#r40968494
Mime
View raw message