jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Phillips <notificati...@github.com>
Subject Re: [jclouds-labs-google] WIP commit for a backport of JCLOUDS-1001 (#169)
Date Wed, 16 Dec 2015 22:42:37 GMT
> @@ -250,7 +251,8 @@ Operation setDiskAutoDelete(@PathParam("instance") String instanceName,
>     @MapBinder(BindToJsonPayload.class)
>     Operation setScheduling(@PathParam("instance") String instanceName,
>                             @PayloadParam("onHostMaintenance") Scheduling.OnHostMaintenance
onHostMaintenance,
> -                           @PayloadParam("automaticRestart") boolean automaticRestart);
> +                           @PayloadParam("automaticRestart") boolean automaticRestart,
> +                           @PayloadParam("preemptible") boolean preemptible);

@nacx **boop boop**...breaking change here. If we wanted to keep a backwards-compatible version
of `setScheduling` too, how would we do that?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/169/files#r47842675
Mime
View raw message