jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Phillips <notificati...@github.com>
Subject Re: [jclouds-labs-google] WIP commit for a backport of JCLOUDS-1001 (#169)
Date Wed, 16 Dec 2015 23:52:43 GMT
> +    * Sets an instance's scheduling options.
> +    * @see <a href = "https://cloud.google.com/compute/docs/instances#onhostmaintenance"/>
> +    *
> +    * @param instanceName The name of the instance
> +    * @param onHostMaintenance either MIGRATE or TERMINATE the default is MIGRATE (Live
Migration).
> +    * @param automaticRestart Defines whether the Instance should be automatically
> +    *  restarted when it is terminated by Compute Engine (not terminated by user).
> +    *  Used when onHostMaintenance is set to TERMINATE.
> +    * @param preemptible Defines whether the Instance should be launched as spot instance
> +    * @return
> +    */
> +   @Named("Instances:setScheduling")
> +   @POST
> +   @Path("/{instance}/setScheduling")
> +   @MapBinder(BindToJsonPayload.class)
> +   Operation setScheduling(@PathParam("instance") String instanceName,

@nacx: Thanks for the review comment. Now adding this as an additional overloaded method.

The tests now only exercise the new method (see below). Add another test for the old overloaded
version?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/169/files#r47850966
Mime
View raw message