jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ignasi Barrera <notificati...@github.com>
Subject Re: [jclouds] [JCLOUDS-1044] fix NULL values handling in TypeAdapterFactories (#887)
Date Thu, 03 Dec 2015 11:30:38 GMT
Thanks @kwart! The change itself LGTM.

The chef provider overrides this behavior, so the fix should be applied [here](https://github.com/jclouds/jclouds/blob/master/apis/chef/src/main/java/org/jclouds/chef/config/ChefParserModule.java#L236)
too. Also, you'll see that the ChefParserModule [copies the entire map adapter](https://github.com/jclouds/jclouds/blob/master/apis/chef/src/main/java/org/jclouds/chef/config/ChefParserModule.java#L208-L209)
(this is a legacy code created when Chef lived in a different Git repo). Could you make the
`NullFilteringTypeAdapterFactories.MapTypeAdapter` non-final, so we can properly override
just the relevant bits?

Just FYI, the difference in the Chef adapter is that it doesn't use an immutbale map to allow
repeated keys and it returns just the last one. Some json returned in Chef use key repetition
to put "comments", and leave the value in the last field. Pretty ugly, I know!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/887#issuecomment-161605353
Mime
View raw message