jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ignasi Barrera <notificati...@github.com>
Subject Re: [jclouds] JCLOUDS-1072 (#912)
Date Tue, 02 Feb 2016 22:55:40 GMT
Thanks for your contribution @rongallagher! Code looks good! There are just very minor comments.
Could you also update the [create Role live test](https://github.com/jclouds/jclouds/blob/master/apis/chef/src/test/java/org/jclouds/chef/ChefApiLiveTest.java#L244-L252),
for completeness?

When making the changes, just add a commit and push the branch; it will automatically show
in the pull request. Thanks for your first contribution to jclouds!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/912#issuecomment-178873855
Mime
View raw message