jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ignasi Barrera <notificati...@github.com>
Subject Re: [jclouds] clean up logic and docs for setting proxies (#914)
Date Fri, 05 Feb 2016 22:18:33 GMT
>        private Type type;
>        private Optional<HostAndPort> proxy;
>        private Optional<Credentials> credentials;
>  
> -      MyProxyConfig(boolean useSystem, Type type, Optional<HostAndPort> proxy,
Optional<Credentials> credentials) {
> +      MyProxyConfig(boolean useSystem, boolean canUseProxyFromJvm, Type type, Optional<HostAndPort>
proxy, Optional<Credentials> credentials) {

Hmmm, this only enables the jvm proxy as a *fallback* if no jclouds proxy properties have
been configured (which will be the most common case in jclouds applications given the current
logic). I'd say that perhaps `enableJvmProxy` could be more clear, but I'm not the language
expert here :)
Not a big deal for me in any case.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/914/files#r52080411
Mime
View raw message