jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Janne Koskinen <notificati...@github.com>
Subject Re: [jclouds/jclouds-labs] JCLOUDS-664 Azurecompute-arm DeploymentApi OSImageApi VMSizeApi (#273)
Date Thu, 26 May 2016 06:28:02 GMT
> +      DeploymentBody body = DeploymentBody.create(template, DEPLOYMENT_MODE, DeploymentTemplate.Parameters.create());
> +
> +      return body;
> +   }
> +
> +
> +   private void addStorageResource() {
> +      String storageAccountName = name.replaceAll("[^A-Za-z0-9 ]", "") + "storage";
> +
> +      variables.put("storageAccountName", storageAccountName);
> +
> +      ResourceDefinition storageAccount = ResourceDefinition.builder()
> +              .name("[variables('storageAccountName')]")
> +              .type("Microsoft.Storage/storageAccounts")
> +              .location(location)
> +              .apiVersion("2015-06-15")

This is little bit tricky. If we have constant like STORAGE_API_VERSION and then we update
it and update also StorageAccountAPI, we may face problems with this part of code. Maybe we
should have that constant but in that case we should be very careful when updating the version
to remember to update all code that is affected.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/273/files/74f8e9bf66e7427298c5c3c9567aa7d8284e0987#r64696785
Mime
View raw message