jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (JCLOUDS-1143) AWSv4SignerBase fails to log canonicalRequest
Date Wed, 10 Aug 2016 22:10:21 GMT

    [ https://issues.apache.org/jira/browse/JCLOUDS-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15416113#comment-15416113
] 

ASF subversion and git services commented on JCLOUDS-1143:
----------------------------------------------------------

Commit e7bf9b129851dcf1af14bd114fa6ffd2d388045e in jclouds's branch refs/heads/gsoc2016-ivan
from neonbunny
[ https://git-wip-us.apache.org/repos/asf?p=jclouds.git;h=e7bf9b1 ]

Ensure the canonicalRequest is logged properly

Resolves JCLOUDS-1143

> AWSv4SignerBase fails to log canonicalRequest
> ---------------------------------------------
>
>                 Key: JCLOUDS-1143
>                 URL: https://issues.apache.org/jira/browse/JCLOUDS-1143
>             Project: jclouds
>          Issue Type: Bug
>          Components: jclouds-blobstore
>    Affects Versions: 2.0.0
>            Reporter: Stephen Tomkinson
>            Assignee: Andrew Gaul
>            Priority: Minor
>             Fix For: 2.0.0
>
>
> The logging of the "canonical request" for AWS v4 signing of S3 requests currently omits
the canonical request string itself. The cause appears to be line 403 (https://github.com/apache/jclouds/blob/18cba94fab010152f00396439c3d1a8bfd9d7681/apis/s3/src/main/java/org/jclouds/s3/filters/Aws4SignerBase.java#L403)
which is using a templated logging call, but passes a logging message String without template
placeholders.
> Elsewhere, String concatenation is used - e.g. https://github.com/apache/jclouds/blob/18cba94fab010152f00396439c3d1a8bfd9d7681/apis/s3/src/main/java/org/jclouds/s3/filters/Aws4SignerForChunkedUpload.java#L191



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message