jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrea Turli <notificati...@github.com>
Subject Re: [jclouds/jclouds-labs-google] add firewalls conditionally (#172)
Date Mon, 01 Aug 2016 08:42:39 GMT
>        Network network = getOrCreateNetwork(templateOptions, sharedResourceName);
> -      getOrCreateFirewalls(templateOptions, network, firewallTagNamingConvention.get(group));
> +      // add firewalls *only* if the template options don't contain explicit network
> +      if (templateOptions.network() == null) {

My idea is the following:
- if the user specifies the network, she knows exactly how it is configured, so there is no
need to create firewall rules. In fact, we could re-create the same logical firewall rule
but with a different name. Consider also that when you have hundreds of fw rules, gce web
ui becomes unresponsive, making deletion particularly boring.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
View raw message