jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrea Turli <notificati...@github.com>
Subject Re: [jclouds/jclouds-labs-google] add firewalls conditionally (#172)
Date Mon, 01 Aug 2016 11:43:15 GMT
>        Network network = getOrCreateNetwork(templateOptions, sharedResourceName);
> -      getOrCreateFirewalls(templateOptions, network, firewallTagNamingConvention.get(group));
> +      // add firewalls *only* if the template options don't contain explicit network
> +      if (templateOptions.network() == null) {

ouch, yes. do you think it is worth to add an additional templateOptions like `ADD_FIREWALLS`
which is by default true to achieve a better result?

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/172/files/a083442f462a4b5dcc0c9dabfcca8a181b8e2889#r72964293
Mime
View raw message