jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrea Turli <notificati...@github.com>
Subject Re: [jclouds/jclouds-labs-google] add firewalls conditionally (#172)
Date Tue, 02 Aug 2016 08:31:51 GMT
>        Network network = getOrCreateNetwork(templateOptions, sharedResourceName);
> -      getOrCreateFirewalls(templateOptions, network, firewallTagNamingConvention.get(group));
> +      // add firewalls *only* if the template options don't contain explicit network
> +      if (templateOptions.network() == null) {

Problem with GCE is that it creates a firewall in a network (`createInNetwork`): security
groups are not modeled, so the wrapping `container` is the Network.
Anyway, thanks for your thoughts. I'll come up with a different patch.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
View raw message