jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ignasi Barrera <notificati...@github.com>
Subject Re: [jclouds/jclouds] add support for security groups (#985)
Date Tue, 02 Aug 2016 13:42:50 GMT
> @@ -186,6 +201,15 @@ private void getOrCreateFirewalls(GoogleComputeEngineTemplateOptions
templateOpt
>           operationDone.apply(operation);
>           checkState(operation.get().httpErrorStatusCode() == null, "Could not insert
firewall, operation failed %s",
>                 operation);
> +
> +         // Add tags for firewalls
> +         tags.add(name);
> +      }
> +   }
> +
> +   public static void validateFirewall(Firewall firewall, URI networkUri) {

Does it make more sense for the signature to be `validateFirewall(Firewall firewall, Network
network)`?

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/985/files/26606de66b847ed40cb2e0d3c84362c1f9ca0963#r73156638
Mime
View raw message