jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Reijhanniel Jearl Campos <notificati...@github.com>
Subject Re: [jclouds/jclouds-labs] Pb compute api (#292)
Date Tue, 04 Oct 2016 03:47:44 GMT
Hello! 

> How close would you say we are to closing this PR

I'd say it's long overdue! Seeing your live tests passing from your gist, I'd say the impl
addresses the contract required by the `ComputeService`. Just some last nitpicks like that
[overriden toString](https://github.com/jclouds/jclouds-labs/pull/292#discussion_r79763475),
and the [formatting in pom](https://github.com/jclouds/jclouds-labs/pull/292#discussion_r79763965).
Otherwise, I'd say this LGTM.

/cc @nacx PR now yours for last review?

---
What're your plans btw after this gets merged? I'd personally like to see:
- Arbitrary CPU/RAM support, as this is [now supported](https://jclouds.apache.org/blog/2016/08/22/arbitrary-cpu-ram/)
- [JCLOUDS-1082](https://issues.apache.org/jira/browse/JCLOUDS-1082) Firewall configurations
- [JCLOUDS-1083](https://issues.apache.org/jira/browse/JCLOUDS-1083) Inbound port configurations

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/292#issuecomment-251289003
Mime
View raw message