jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ignasi Barrera <notificati...@github.com>
Subject Re: [jclouds/jclouds-labs] Pb compute api (#292)
Date Thu, 06 Oct 2016 09:05:53 GMT
nacx commented on this pull request.

Just one minor comment on my side regarding the logger. Once it is amended, I'm happy to finally
merge this!
Great work @alibazlamit, and apologies for the late review! It is quite difficult to review
big PRs like this.

> +                          .build()
+                  );
+               }
+            }));
+
+            logger.trace(">> volume connected.");
+         } catch (Exception ex) {
+            try {
+               // delete unconnected volume
+               logger.warn(ex, ">> failed to connect volume '%s'. deleting..", volumeId);
+               destroyVolume(volumeId, dataCenterId);
+               logger.warn(ex, ">> rolling back server..", serverId);
+               destroyServer(serverId, dataCenterId);
+               throw ex;
+            } catch (Exception ex1) {
+               java.util.logging.Logger.getLogger(ProfitBricksComputeServiceAdapter.class.getName()).log(Level.SEVERE,
null, ex1);

Change to the jclouds logger used in this class.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/292#pullrequestreview-3071660
Mime
View raw message