jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ignasi Barrera <notificati...@github.com>
Subject Re: [jclouds/jclouds-labs] JCLOUDS-1183 - oneandone-monitoringcenter-api (#322)
Date Fri, 07 Oct 2016 13:51:47 GMT
nacx commented on this pull request.



> @@ -202,4 +202,20 @@ public static VPNType fromValue(String v) {
          return Enums.getIfPresent(VPNType.class, v).or(UNRECOGNIZED);
       }
    }
+
+   public enum PeriodType {
+      LAST_HOUR, LAST_24H, LAST_7D, LAST_30D, LAST_365D, UNRECOGNIZED;
+
+      public static PeriodType fromValue(String v) {
+         return Enums.getIfPresent(PeriodType.class, v).or(UNRECOGNIZED);
+      }
+   }
+
+   public enum CustomPeriodType {
+      CUSTOM, UNRECOGNIZED;

Oh, I see. This way you avoid users calling the `FixedPeriods` options method with the wrong
type. Thanks for clarifying!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/322
Mime
View raw message